Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #25 : Add option to lock Home screen #39

Closed
wants to merge 8 commits into from

Conversation

Sinexo
Copy link

@Sinexo Sinexo commented May 9, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Updated Config
  • Updated Constant
  • Updated Mainactivity
  • Updated SettingsActivity
  • Updated activity_setting

Fixes the following issue(s)

Relies on the following changes

  • Add option in the settings to lock the home screen, no app, pages or widget can be deleted/moved. App can still be unistalled from the app screen.

Acknowledgement

@naveensingh
Copy link
Member

naveensingh commented Jul 25, 2024

I don't think this is the right way to do it. It works but it works a little bit too much. One can't 'Uninstall app' or view 'App info' because long press menu is completely disabled. Only actions that would directly affect the home screen layout should be hidden/disabled.

The preference name should be a little more descriptive like 'Lock home screen layout' or 'Lock layout' under the 'Home screen' section.

If you still want to work on this feature, please raise a new PR (after the initial release) taking into account the above suggestions. I'll be closing this one because soon there will be a lot of changes in the main branch thus too many conflicts to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants