Skip to content

Commit

Permalink
JA4H: Sort cookie-pairs properly (#70)
Browse files Browse the repository at this point in the history
Don't sort cookie-strings. Instead, split the cookie-pair on the first `'='`
and sort the vector of `(cookie-name, cookie-value)`.

Kudos to @awick for reporting the bug and explaining the correct semantics!

Closes #58
  • Loading branch information
vvv authored Feb 5, 2024
1 parent db49b59 commit 16e9298
Show file tree
Hide file tree
Showing 6 changed files with 206 additions and 82 deletions.
9 changes: 8 additions & 1 deletion rust/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.18.1] - 2024-02-04

### Fixed

- JA4H: Sort cookie-pairs properly (#58).

## [0.18.0] - 2024-02-04

### Fixed
Expand Down Expand Up @@ -77,7 +83,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Add Rust sources of `ja4` and `ja4x` CLI tools.

[unreleased]: https://github.com/FoxIO-LLC/ja4/compare/v0.18.0...HEAD
[unreleased]: https://github.com/FoxIO-LLC/ja4/compare/v0.18.1...HEAD
[0.18.1]: https://github.com/FoxIO-LLC/ja4/compare/v0.18.0...v0.18.1
[0.18.0]: https://github.com/FoxIO-LLC/ja4/compare/v0.17.0...v0.18.0
[0.17.0]: https://github.com/FoxIO-LLC/ja4/compare/v0.16.2...v0.17.0
[0.16.2]: https://github.com/FoxIO-LLC/ja4/compare/v0.16.1...v0.16.2
Expand Down
27 changes: 2 additions & 25 deletions rust/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ members = ["ja4", "ja4x"]
resolver = "2"

[workspace.package]
version = "0.18.0"
version = "0.18.1"
license = "LicenseRef-FoxIO-Proprietary"
repository = "https://github.com/FoxIO-LLC/ja4"

Expand Down
1 change: 0 additions & 1 deletion rust/ja4/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,3 @@ tracing-subscriber.workspace = true
[dev-dependencies]
expect-test = "1.4"
insta = { version = "1.33", features = ["glob", "yaml"] }
pretty_assertions = "1.4"
Loading

0 comments on commit 16e9298

Please sign in to comment.