Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite to use the new tpmdirect API from go-tpm #9

Merged
merged 18 commits into from
Jul 10, 2023
Merged

Rewrite to use the new tpmdirect API from go-tpm #9

merged 18 commits into from
Jul 10, 2023

Conversation

Foxboron
Copy link
Owner

@Foxboron Foxboron commented Jul 8, 2023

No description provided.

@Foxboron
Copy link
Owner Author

Foxboron commented Jul 8, 2023

@chrisfenner I don't know if you are interested, but here is a rewrite of age-plugin-tpm from the legacy tpm2 API to the new tpmdirect API.

I'm not sure if this works as some form of feedback or if this helps on the API design :)

@Foxboron
Copy link
Owner Author

Foxboron commented Jul 9, 2023 •
edited
Loading

Hrm, actually I tired running this on my actual TPM instead of the swtpm stuff and it fails to do ECDHZGen. Just blocks without any response from the TPM.

Age interrupting the plugin too quickly it seems(?)

@Foxboron
Rewrite to use the new tpmdirect API from go-tpm
d8a916d 
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
age-plugin-tpm: Simplify output file handling
8967085 
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
key_test: unused function mustPack
3c7978e 
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
key_test: Add decode with HasPIN
2d27a2e 
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
tpm: implement support for creating keys with PIN
a11240c 
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
plugin: Slight structure change for the stanza parser
00f4902 
We get a stanza, and we should reply with a stanza. Previously we would
intermingle this which would probably lead to a couple of subtle bugs

This also implements multiple recipients.
@Foxboron
plugin: ask age for a pin when the key requires it
9d4e6b6
@Foxboron
plugin: Add error handling
c0bdb65 
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron Foxboron force-pushed the morten/tpmdirect branch 2 times, most recently from db93c1c to d26b975 Compare July 10, 2023 14:10
@Foxboron Foxboron mentioned this pull request Jul 10, 2023
Closed
chrisfenner
chrisfenner reviewed Jul 10, 2023
View reviewed changes
plugin/key.go Show resolved Hide resolved
plugin/key_test.go Outdated Show resolved Hide resolved
plugin/key_test.go Outdated Show resolved Hide resolved
plugin/plugin.go Outdated Show resolved Hide resolved
plugin/plugin.go Outdated Show resolved Hide resolved
plugin/plugin.go Outdated Show resolved Hide resolved
plugin/plugin.go Outdated Show resolved Hide resolved
plugin/plugin.go Show resolved Hide resolved
plugin/plugin.go Outdated Show resolved Hide resolved
@chrisfenner
Copy link

definitely interested, thanks for tagging me! I have filed a feature request for go-tpm to add a UnmarshalReader/MarshalReader surface, and left a few other comments on the design of your code here. Thanks for using the new go-tpm API!!

@Foxboron
Copy link
Owner Author

definitely interested, thanks for tagging me! I have filed a feature request for go-tpm to add a UnmarshalReader/MarshalReader surface, and left a few other comments on the design of your code here. Thanks for using the new go-tpm API!!

Thank you very much for taking the time to review the code :)

@Foxboron
key_test: simplify byte type conversion
1ee3993 
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
plugin: Inline Create and CreatePrimary
72ff466 
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
plugin: encrypt the response from the ecdh command
2c90308 
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
plugin: Don't call GetPubKey, we have the pubkey
9acb3a0 
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
tpm: Partition up functions and control handles better in each callin…
06214d2 
…g function

Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
tpm: remove FlusHandles and the handle caching
bb8af25 
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
age-plugin-tpm: Be more defensive in-case we get recipients we dont u…
0306eee 
…nderstand

Signed-off-by: Morten Linderud <[email protected]>
@Foxboron
age-plugin-tpm: fix example in help
3ee4373 
Signed-off-by: Morten Linderud <[email protected]>
@Foxboron Foxboron merged commit 3ee4373 into master Jul 10, 2023
@Foxboron Foxboron mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisfenner chrisfenner chrisfenner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Foxboron @chrisfenner