Pin rollup version to fix tree shaking bugs #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of rollup have started tree shaking by removing bindings while leaving the assignment expressions in the code. This breaks `lottie-web` or any package which binds to a function like this:
```js
var foo = function bar() {
}.bind(this);
```
This is being compiled to:
```js
function bar() {
}.bind(this);
```
There might be other cases where removing the binding is also not safe.
Solution is to pin to the previous working version of rollup.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/afy4wptkv |
drwpow
approved these changes
Feb 4, 2021
|
LGTM, +1 on doing this until that issue is fixed |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
BUG FIX
Recent versions of rollup have started tree shaking by removing bindings while leaving the assignment expressions in the code. This breaks
lottie-webor any package which binds to a function like this:This is being compiled to:
There might be other cases where removing the binding is also not safe.
Solution is to pin to the previous working version of rollup.
Testing
Adds a test with the exact scenario.
Docs
N/A