Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the bug that if the hmrPort != port, a server is not started on the hmrPort and HMR doesn't work
Changes
If the server is supplied it is not checking to see whether the hmrPort is different to the server port. If it is different, a new server needs to be started on the HMR port. Supplying null to her-server-enngine will cause it to start a new server on that port
Testing
tested locally with hmrPort!=port, works correctly
Docs