Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hmr.ts #3856

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update hmr.ts #3856

wants to merge 1 commit into from

Conversation

xrgaddtt2
Copy link

This is to fix the bug that if the hmrPort != port, a server is not started on the hmrPort and HMR doesn't work

Changes

If the server is supplied it is not checking to see whether the hmrPort is different to the server port. If it is different, a new server needs to be started on the HMR port. Supplying null to her-server-enngine will cause it to start a new server on that port

Testing

tested locally with hmrPort!=port, works correctly

Docs

This is to fix the bug that if the hmrPort != port, a server is not started on the hmrPort and HMR doesn't work
@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2022

⚠️ No Changeset found

Latest commit: cb76d4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/8sbabj81NQoeCqUyC8Rgidp8Uhww
✅ Preview: https://snowpack-git-fork-xrgaddtt2-patch-1-pikapkg.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant