modify entrypoints.ts to handle wildcards in package.json export node… #3890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… recursively
Changes
This PR addresses the issue described here: #3867
The current function only returns paths to modules that are in the top level of the directory, but it should return all files in the subdirectories according to this: https://nodejs.org/api/packages.html#subpath-patterns. To fix this, I modified the function
forEachWildcardEntry()
to yield files in subdirectories.Testing
I tested this in my local environment and can now import modules that are in subdirectories of wildcard entries of the export field of the package.json
Docs