Fix cache value being promise in ubuntu #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #877
This was a crazy bug and I would definitely need more investigation to confirm but it seems that then blocks that are created after the promise is resolved doesn't get called within ubuntu. I think that is against A+ promise spec but it has been awhile since I took a look at that...
But what we were doing is that we would cache the promise object and chain the then from there, however for whatever reason ubuntu couldn't chain then functions when promise is already resolved and cache was useless as we weren't able to extract the value.
This fix is to store hard value if cached function result value is a promise.
This is a fun bug and I'm interested in seeing how the OS diff cause this subtle bug...