Update libraries to LTS 2.0 version. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does this merge include coreHTTP? |
krantik
reviewed
Sep 28, 2022
No, it's not included. Remove wrong description. |
adam-scislowicz
previously approved these changes
Oct 27, 2022
| @@ -58,7 +58,7 @@ extern void vLoggingPrintf( const char * pcFormat, | |||
| #define configUSE_DAEMON_TASK_STARTUP_HOOK 1 | |||
| #define configCPU_CLOCK_HZ ( SystemCoreClock ) | |||
| #define configTICK_RATE_HZ ( ( TickType_t ) 1000 ) | |||
| #define configMAX_PRIORITIES ( 7 ) | |||
| #define configMAX_PRIORITIES ( 9 ) | |||
There was a problem hiding this comment.
Why are we changing the maximum priority from 7 to 9?
There was a problem hiding this comment.
After commit in kernel, it triggered an assertion because task priority is larger than max priorities. That's why I enlarge it here.
Fixed. Thanks! |
adam-scislowicz
approved these changes
Oct 31, 2022
AniruddhaKanhere
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update libraries to LTS 2.0 version, including: