-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/new window right click #2027
Feature/new window right click #2027
Conversation
…xt of a context menu
I think this PR will conflict with Not sure why that PR takes so long to be reviewed :S |
when your pr will be merged I will use your more comprehensive/elegant implementation of |
I prefer that style much more than positional arguments especially when there are many arguments / optional arguments |
I can fix it too (open in new window a youtube link in the description using right click), I'm not sure I understand what is in parathesis. |
I am developing the fix already, figuring out how to handle |
A bigger problem is a few PR stuck by not having a 3rd reviewer =_=||| |
ok, I let you do it and I will wait for the reviews. |
Head branch was pushed to by a user without write access
@efb4f5ff-1298-471a-8973-3d47447115dc @constraintAutomaton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to work fine. LGTM
@efb4f5ff-1298-471a-8973-3d47447115dc Kind of confusing when I first read your last message here... |
Will review remaining PR this week... or next |
Head branch was pushed to by a user without write access
we'll be updating that action soon. Don't worry about making it pass for the time being |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally
305f288
Just fixed it |
thank you! |
@ChunkyProgrammer @absidue Please review 👋 |
@PikachuEXE we need @PrestonN to approve (even if we approve it won't be merged until he approves it as he requested changes) |
Cant we dismiss his review somehow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will he comeback "soon" or should I close the PR and create a new one? |
Dismiss Prestons review
Feature/new window right click
Pull Request Type
Related issue
closes #2000
Description
When right-clicking a link, a video or a channel image a context menu appears giving the option to open the source into a new window.
Screenshots
Testing
Right click on a link or video and check if it is open in a new window.
Desktop
Additional context