Improve system locale selection #2271
Conversation
ChunkyProgrammer
changed the title
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
|
While testing this my locale wasnt found and it still defaulted to language based on IP |
This PR only affects FreeTube UI language. (It will see if there's a weblate language that matches closely to it). For example, if the system locale is set to "es-US" for spanish US then setting FreeTube's language to "system" will make the UI match the "es" translation instead of the default "en-US" |
| targetLocale = Object.keys(i18n.messages).find((locale) => { | ||
| const localeName = locale.replace('-', '_') | ||
| return localeName.includes(systemLocale.replace('-', '_')) | ||
| const systemLocaleName = systemLocale.replace('-', '_') |
There was a problem hiding this comment.
Maybe good to put example value(s) in code comments (whole section not just this line)
I can't understand this code section easily
There was a problem hiding this comment.
@efb4f5ff-1298-471a-8973-3d47447115dc
I guess I should mark as requested for change - -?
I think the variable names are quite ambiguous
i.e.
systemLocalesystemLocaleNamesystemLocaleLang
One of the things I can think of is to add example value(s) in form of code comments
So that the readers know what kind of values those variables would store
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
ChunkyProgrammer
dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc and absidue
via
c16ecc8
ChunkyProgrammer
added
PR: waiting for review
ChunkyProgrammer
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
absidue
github-actions
bot
removed
the
PR: waiting for review
Improve system locale selection
Pull Request Type
Please select what type of pull request this is:
Related issue
None
Description
For locale set to system, If a user's system locale is not found then it will default to a locale with the same language instead of defaulting to 'en-US'
Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?
Yes this PR has been tested by hardcoding the value here to a different locale:
https://github.com/FreeTubeApp/FreeTube/pull/2271/files#diff-ef55248451a73d0a2680edeb9d5bbd8a6d0a3deaa89406c100d29fef7a45e497R236
Desktop (please complete the following information):