Fix the redundant navigation error

[absidue]

---

Fix the redundant navigation error

Pull Request Type

• Bugfix

Description

Fixes the issue where spamming the nav buttons throws vue errors about redundant navigations.

Screenshots (if appropriate)

Testing (for code that is not small enough to be easily understandable)
I spammed the nav buttons and the error didn't occur anymore.

Desktop (please complete the following information):

• OS: Windows
• OS Version: 10
• FreeTube version: 7287e00

Additional context
Add any other context about the problem here.

[ChunkyProgrammer]

Error still appears when clicking the profile select's setting icon

[absidue]

@ChunkyProgrammer Thanks for noticing that, should be fixed now.

[ChunkyProgrammer]

Was able to have this error happen again when searching (search the same thing twice)

[vallode]

Potentially we need to hijack the prototype of the vue-router push function here? I mean is it feasible to expect every single next router interaction to always remember to put this if statement in place?

[absidue]

I thought about that but I haven't looked into the source code for that yet (if you want to take a look remember to look at the source code for the version that FreeTube uses). Although I'll need to expand the checks to also check the query parameters etc.

[absidue]

I've now removed the individual checks and wrapped the router push function in one that checks the path and query before navigating.

[PikachuEXE]

Can we have a summary of what to be tested?

• spamming the nav buttons
• clicking the profile select's setting icon
• search the same thing twice
• Paste a YT Video URL to navbar, press arrow button multiple times
• Anything else?

[PikachuEXE]

Tested

• spamming the nav buttons
• clicking the profile select's setting icon
• search the same thing twice
• Paste a YT Video URL to navbar, press arrow button multiple times

[PikachuEXE]

Cleanup duplicate statements (especially conditional)

isQueryEmpty can also be removed

[efb4f5ff-1298-471a-8973-3d47447115dc]

LGTM

[efb4f5ff-1298-471a-8973-3d47447115dc]

@ChunkyProgrammer sorry for the spam :D

[PikachuEXE]

@efb4f5ff-1298-471a-8973-3d47447115dc
Why Is It Called Spam? - https://youtu.be/Wo9QkKxTT1w