Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix channel names being cut off #2292

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Fix channel names being cut off #2292

merged 1 commit into from
Jun 21, 2022

Conversation

vallode
Copy link
Contributor

@vallode vallode commented Jun 5, 2022 •
edited
Loading

Fix channel names being cut off

Pull Request Type
Please select what type of pull request this is:

  • Bugfix

Related issue
Closes #2291

Description
Adds ellipsis overflow to featured channel names

Testing

  1. Go to channel: https://www.youtube.com/c/Whitelight
  2. Go to "About" tab
  3. Compare Feature Channel "MandaloreGaming" between upstream and PR.

Screenshots (if appropriate)
Before:
image

After:
image

Desktop (please complete the following information):

  • OS: [e.g. iOS] 10
  • OS Version: [e.g. 22] Debian
  • FreeTube version: [e.g. 0.8] upstream/development

@PrestonN PrestonN enabled auto-merge (squash) June 5, 2022 09:37
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 5, 2022
@PikachuEXE
Copy link
Collaborator

How do I test this ?_?

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@vallode could u maybe provide a usecase?

@vallode
Copy link
Contributor Author

vallode commented Jun 20, 2022

@efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE provided a test case in the PR description, just go to Whitelight youtube channel and check the featured channels.

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

PikachuEXE
PikachuEXE approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested
Now I notice it's fixing the cut off of long channel name

@PrestonN PrestonN merged commit 8d816ed into FreeTubeApp:development Jun 21, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 21, 2022
@vallode vallode deleted the fix/channel-bubble-cutoff branch June 21, 2022 08:01
@MarmadileManteater MarmadileManteater mentioned this pull request Jun 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Featured Channels names are being cut off
5 participants
@vallode @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @PrestonN