Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update electron-builder version to ^23.0.2 #2305

Merged

Conversation

PikachuEXE
Copy link
Collaborator

Pull Request Type
Please select what type of pull request this is:

  • Bugfix

Related issue
N/A

Description
Fixes build task on MacOS 12.3+
Reported in electron-userland/electron-builder#6726

Screenshots (if appropriate)
Error message before update
image

Testing (for code that is not small enough to be easily understandable)

  • Update to MacOS 12.4
  • yarn run build

Desktop (please complete the following information):

  • OS: MacOS
  • OS Version: 12.4
  • FreeTube version: e861e70

Additional context
Add any other context about the problem here.

Fixes build task on MacOS 12.3+
@PrestonN PrestonN enabled auto-merge (squash) June 11, 2022 02:28
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Jun 11, 2022
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build still works properly on Windows after the update.

@PikachuEXE
Copy link
Collaborator Author

If you want to look for breaking changes in 23.x:

But the changelog format looks so strange

@efb4f5ff-1298-471a-8973-3d47447115dc

mirror mirror on the wall who is the chunkiest of them all? @ChunkyProgrammer

@PikachuEXE
Copy link
Collaborator Author

Chunkiest 👀

@PrestonN PrestonN merged commit 6e25d35 into FreeTubeApp:development Jun 21, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 21, 2022
@PikachuEXE PikachuEXE deleted the update/electron-builder-23.x branch June 21, 2022 09:25
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jun 23, 2022
…uilds/build-more-versions

* commit '4f4f727ae1af304ce3131f03b29383ce4fdbb724': (104 commits)
  Translated using Weblate (Italian)
  Translated using Weblate (Chinese (Traditional))
  Translated using Weblate (Arabic)
  Translated using Weblate (Polish)
  Translated using Weblate (Ukrainian)
  Translated using Weblate (French)
  Translated using Weblate (French)
  Translated using Weblate (Turkish)
  Translated using Weblate (Hebrew)
  Translated using Weblate (Icelandic)
  Translated using Weblate (Chinese (Simplified))
  Translated using Weblate (Turkish)
  Translated using Weblate (French)
  Add Parental Controls (FreeTubeApp#1456)
  Translated using Weblate (Chinese (Traditional))
  Translated using Weblate (Chinese (Simplified))
  Make installation method and API method mandatory in bug issue template (FreeTubeApp#2342)
  Fix removing the meta files when navigating to a new video (FreeTubeApp#2344)
  * Update app menu to add item for new window (FreeTubeApp#2306)
  Update electron-builder version to ^23.0.2 (FreeTubeApp#2305)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants