-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update electron-builder version to ^23.0.2 #2305
Merged
PrestonN
merged 1 commit into
FreeTubeApp:development
from
PikachuEXE:update/electron-builder-23.x
Jun 21, 2022
Merged
Update electron-builder version to ^23.0.2 #2305
PrestonN
merged 1 commit into
FreeTubeApp:development
from
PikachuEXE:update/electron-builder-23.x
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes build task on MacOS 12.3+
PikachuEXE
requested review from
PrestonN,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
June 11, 2022 02:27
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: dependencies
Pull requests that update a dependency file
PR: waiting for review
For PRs that are complete, tested, and ready for review
labels
Jun 11, 2022
absidue
approved these changes
Jun 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build still works properly on Windows after the update.
If you want to look for breaking changes in 23.x:
But the changelog format looks so strange |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 19, 2022
mirror mirror on the wall who is the chunkiest of them all? @ChunkyProgrammer |
Chunkiest 👀 |
ChunkyProgrammer
approved these changes
Jun 21, 2022
github-actions
bot
removed
the
PR: waiting for review
For PRs that are complete, tested, and ready for review
label
Jun 21, 2022
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 23, 2022
…uilds/build-more-versions * commit '4f4f727ae1af304ce3131f03b29383ce4fdbb724': (104 commits) Translated using Weblate (Italian) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Arabic) Translated using Weblate (Polish) Translated using Weblate (Ukrainian) Translated using Weblate (French) Translated using Weblate (French) Translated using Weblate (Turkish) Translated using Weblate (Hebrew) Translated using Weblate (Icelandic) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Turkish) Translated using Weblate (French) Add Parental Controls (FreeTubeApp#1456) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Make installation method and API method mandatory in bug issue template (FreeTubeApp#2342) Fix removing the meta files when navigating to a new video (FreeTubeApp#2344) * Update app menu to add item for new window (FreeTubeApp#2306) Update electron-builder version to ^23.0.2 (FreeTubeApp#2305) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please select what type of pull request this is:
Related issue
N/A
Description
Fixes build task on MacOS 12.3+
Reported in electron-userland/electron-builder#6726
Screenshots (if appropriate)
Error message before update
Testing (for code that is not small enough to be easily understandable)
yarn run build
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.