Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapping the Invidious API field to the view #2483

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Mapping the Invidious API field to the view #2483

merged 1 commit into from
Aug 15, 2022

Conversation

MarmadileManteater
Copy link
Contributor

Mapping the Invidious API field "authorId" to the expected field "channelId"

Pull Request Type
Please select what type of pull request this is:

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue
closes #2481

Description
Added a line to map the field "authorId" to "channelId"
on the featured channels that come from the Invidious API
because the Channel view expects related channels to have
the property "channelId".

<!-- line 130 of src/renderer/views/Channel/Channel.vue -->
<ft-channel-bubble
  v-for="(channel, index) in relatedChannels"
  :key="index"
  :channel-name="channel.author || channel.channelName"
  :channel-id="channel.channelId"
  :channel-thumbnail="channel.authorThumbnails[channel.authorThumbnails.length - 1].url"
  @click="goToChannel(channel.channelId)"
/>

Desktop (please complete the following information):

  • OS: Windows 10
  • OS Version: Pro Version 21H2 Installed on ‎4/‎3/‎2022 OS build 19044.1889 Experience Windows Feature Experience Pack 120.2212.4180.0
  • FreeTube version: 0.17.1

@MarmadileManteater
Mapping the invidious API field to the view
73d84ed 
Added a line to map the field "authorId" to "channelId"
on the featured channels that come from the Invidious API
because the Channel view expects related channels to have
the property "channelId". This is related to FreeTubeApp#2481.
@PrestonN PrestonN enabled auto-merge (squash) August 15, 2022 16:33
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 15, 2022
ChunkyProgrammer
ChunkyProgrammer approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thankyou :)

@PrestonN PrestonN merged commit 33cf88c into FreeTubeApp:development Aug 15, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 15, 2022
@MarmadileManteater MarmadileManteater deleted the upstream-development branch August 17, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE Awaiting requested review from PikachuEXE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Featured Channels throw error on click (only while using the Invidious API)
5 participants
@MarmadileManteater @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @PrestonN