Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase width of quality selector so that 1080p60 doesn't overflow into the full screen button #2556

Merged

Conversation

absidue
Copy link
Member

@absidue absidue commented Sep 9, 2022


Increase width of quality selector so that 1080p60 doesn't overflow into the full screen button

Pull Request Type

  • Bugfix

Description
Fix the quality selector button overflowing into the full screen button when it has wide values like 1080p60 in it.

Screenshots
before:
before
after:
after

Testing (for code that is not small enough to be easily understandable)
https://www.youtube.com/watch?v=zCLOJ9j1k2Y (select 1080p60)

Desktop (please complete the following information):

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.17.1

@absidue absidue added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 9, 2022
@PrestonN PrestonN enabled auto-merge (squash) September 9, 2022 17:17
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested

@PrestonN PrestonN merged commit 644df97 into FreeTubeApp:development Sep 10, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 10, 2022
@absidue absidue deleted the wider-quality-selector-button branch September 10, 2022 14:15
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Sep 11, 2022
* development:
  Translated using Weblate (Spanish)
  Don't log any errors if there are no SponsorBlock segments (FreeTubeApp#2555)
  Add Scoop to readme, issue template and label workflow (FreeTubeApp#2553)
  Build and release 7zip artifacts (FreeTubeApp#2558)
  Increase width of quality selector so that 1080p60 doesn't overflow into the full screen button (FreeTubeApp#2556)
  Translated using Weblate (Russian)
  Localization inconsistency fix for Local API (FreeTubeApp#2535)
  Translated using Weblate (Italian)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants