Fix for Region for Trending dropdown not populating
#2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only settings which have a user defined value would be iterated on in this loop. Now, all settings that have a user defined value or that have side effects will be iterated. This is important because `currentLocale`'s side effect handler contains a call to `getRegionData`, and if this side effect handler is never called, the `Region for Trending` option in settings will never populate.
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
requested review from
ChunkyProgrammer,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
PikachuEXE
ChunkyProgrammer
approved these changes
Oct 18, 2022
absidue
approved these changes
Oct 18, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
Region for Trendingdropdown not populatingPull Request Type
Related issue
#1644
Description
This PR aims to fix an issue with the
Region for Trendingdropdown not populating with data before the user changes thecurrentLocale.Screenshots
Before:
After:
Testing
settings.dbfile (I believe it is located in theElectronroaming directory when debugging)Region for Trendingdropdown in settingsDesktop (please complete the following information):
Additional Information
An alternative solution might be to add an additional call to
getRegionDatasomewhere; however, it may be difficult to tell ifgetRegionDatahas already been called recently without introducing a race condition. That could causegetRegionDatato be called twice in a row. The reason I went with this solution was because this issue goes away when all of the side effects are evaluated on app mounted.