Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cached subscription videos when removing all subscriptions #2905

Merged

Conversation

absidue
Copy link
Member

@absidue absidue commented Dec 1, 2022

Clear cached subscription videos when removing all subscriptions

Pull Request Type

  • Bugfix

Description

Currently when you remove all subscriptions and profiles, the cached subscription videos stay in the subscriptions tab, this PR fixes this by clearing/resetting that cache when all subscriptions and profiles are removed.

Testing

  1. Import your subscriptions/subscribe to a few channels
  2. Select the all channels profile
  3. Refresh your subscriptions
  4. In the privacy settings click "Remove All Subscriptions / Profiles"
  5. Switch to the subscripitons tab, it should be empty

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.18.0

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 1, 2022 22:18
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 1, 2022
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

@FreeTubeBot FreeTubeBot merged commit c1f257d into FreeTubeApp:development Dec 2, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 2, 2022
@absidue absidue deleted the clear-cached-subscriptions branch December 2, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants