Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure window is visible #3008

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Make sure window is visible #3008

merged 1 commit into from
Feb 6, 2023

Conversation

kawanakaiku
Copy link
Contributor

@kawanakaiku kawanakaiku commented Dec 28, 2022 •
edited by efb4f5ff-1298-471a-8973-3d47447115dc
Loading

Title

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #1938
closes #3007
closes #2205

Description

Adds check if window is visible on screen.

Screenshots

Testing

After disconnecting sub display, the window is displayed in the initial position.

Desktop

  • OS: Windows 11
  • OS Version: 22H2
  • FreeTube version: v0.18.0-beta

Additional context

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 28, 2022
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 28, 2022 16:27
@PikachuEXE
Copy link
Collaborator

I don't have multiple monitor to test this...

ChunkyProgrammer
ChunkyProgrammer reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, haven't tested yet

PikachuEXE
PikachuEXE reviewed Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone able to test this?
Code lgtm

@ChunkyProgrammer
Copy link
Member

Tested and it worked for my setup, I'd like to test #2205 before I approve just in case

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Can somebody make a build for me so i can install and test properly with multiple moniters

Closed
1 task
@ChunkyProgrammer
Copy link
Member

Can somebody make a build for me so i can install and test properly with multiple moniters

https://github.com/ChunkyProgrammer/FreeTube/actions/runs/4098212368

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
tested it like this on win10

Case 1:
main screen 1 is laptop
screen 2 is monitor

Move FreeTube to your second monitor
Close FreeTube
Turn off or disconnect your second monitor
Open FreeTube

no issues found on either turning off monitor or disconncting

Case2:
main screen 1 is monitor
screen 2 is laptop

Move FreeTube to your second monitor
Close FreeTube
Turn off or disconnect your second monitor
Open FreeTube

no issues found on either turning off monitor or disconncting

@FreeTubeBot FreeTubeBot merged commit edcd5ed into FreeTubeApp:development Feb 6, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue Awaiting requested review from absidue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@kawanakaiku @PikachuEXE @ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc @FreeTubeBot