Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo causing the subtitle sorting to error #3100

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fix typo causing the subtitle sorting to error #3100

merged 1 commit into from
Jan 23, 2023

Conversation

absidue
Copy link
Member

@absidue absidue commented Jan 21, 2023

Fix typo causing the subtitle sorting to error

Pull Request Type

  • Bugfix

Related issue

closes #3095
closes #3071

Description

Fix the subtitles button not showing up as the sorting was erroring, as the language_code property didn't exist.

Testing

Set FreeTube to a language other than english
Check that the subtitles button shows up on the videos provided in the issue:
https://youtu.be/TwJcSD7WsB0
https://youtu.be/3WvRrm2at3w

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.18.0

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 21, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 21, 2023 16:09
PikachuEXE
PikachuEXE approved these changes Jan 22, 2023
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both videos

@FreeTubeBot FreeTubeBot merged commit 633a20a into FreeTubeApp:development Jan 23, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 23, 2023
@absidue absidue deleted the fix-subtitle-typo branch January 23, 2023 12:04
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: missing subtitle button [Bug]: missing subtitles
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot