Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce overflow in playlist view #3123

Merged

Conversation

MarmadileManteater
Copy link
Contributor

Reduce overflow in playlist view

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Description

The videos in the playlist view overflow the screen if the window is narrow enough ( < 550px). They also overflow their container when the screen is between 850px~1000px wide. This PR aims to address these things by making the thumbnail images more responsive.

Screenshots

Before After
before after
before-widerscreens after-widerscreens

Testing

  1. Navigate to a playlist (ex: https://youtube.com/playlist?list=PL25E387C266BEFA18)
  2. Shrink the window to a width below 550px
  3. Make sure the videos do not overflow the window or their container

Desktop

  • OS: Windows 10
  • OS Version: Pro Version 21H2 Installed on ‎4/‎3/‎2022 OS build 19044.1889 Experience Windows Feature Experience Pack 120.2212.4180.0
  • FreeTube version: 0.18.0

Additional Information

I adjusted the ft-list-item styles to be more specific. The thumbnail Image had transitions for all of its properties (including width), so I made it more specific to avoid issues with the width animating for thumbnail images on videos which have already been watched.

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 27, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 27, 2023 23:01
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve since Pokémon Anime BGM provided 🤣

image

@FreeTubeBot FreeTubeBot merged commit 7640a93 into FreeTubeApp:development Jan 30, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 30, 2023
@MarmadileManteater MarmadileManteater deleted the playlist-overflow branch March 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants