Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when playing video with playlist with Indivious API and... #3294

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Mar 13, 2023

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

N/A

Description

  1. Playing a video with playlist with Invidious API would result in error about playlist request
    Due to incorrect input in code

  2. Loading comment with different sort results in not loading not all comments
    See Fix error when playing video with playlist with Indivious API and... #3294 (review)

Screenshots

Expected request
image

Testing

(1):

(2):

Desktop

  • OS: MacOS
  • OS Version: 12.6.3
  • FreeTube version: f44ad64

Additional context

Was testing #3293 then #3231 then discover this

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 13, 2023 06:00
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 13, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but i noticed something weird

VirtualBoxVM_clwSLKxhKw.mp4

@PikachuEXE
Copy link
Collaborator Author

Another bug on FT or Invidious API only?
i.e. Local API got issue as well?

@efb4f5ff-1298-471a-8973-3d47447115dc

Only with Invidious

@PikachuEXE
Copy link
Collaborator Author

I have also fixed that now

@PikachuEXE PikachuEXE changed the title Fix error when playing video with playlist with Indivious API Fix error when playing video with playlist with Indivious API and... Mar 14, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@FreeTubeBot FreeTubeBot merged commit a878ff3 into FreeTubeApp:development Mar 14, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants