Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update watch page to stop at end of playlist (when loop disabled) without countdown #3362

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Mar 27, 2023

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

N/A

Description

Found it weird to see countdown at the end of playlist before seeing "The playlist has ended"
This PR makes it shows that message immediately without countdown

Countdown unchanged when loop enabled/playlist not ended

Screenshots

Testing

Matrix A x B x C
A

  • Not last video in playlist
  • Last video in playlist

B

  • Loop disabled
  • Loop enabled

C

  • Random sort disabled
  • Random sort enabled

Only these combinations should show "The playlist has ended" immediately

  • A: Last video in playlist
  • B: Whatever
  • C: Whatever

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 27, 2023 08:04
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 27, 2023
@absidue
Copy link
Member

absidue commented Apr 22, 2023

When looping is enabled and it switches to the next video, the toast with "The playlist has ended. Enable loop to continue playing" shows up. We probably shouldn't tell the user to enabling looping when it's already enabled.
with-loop

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@PikachuEXE
Copy link
Collaborator Author

@efb4f5ff-1298-471a-8973-3d47447115dc

When looping is enabled and it switches to the next video, the toast with "The playlist has ended. Enable loop to continue playing" shows up. We probably shouldn't tell the user to enabling looping when it's already enabled. with-loop

lol wanted to create an issue for that because i also noticed that in this PR

@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 26, 2023
@FreeTubeBot FreeTubeBot merged commit 0e11fd0 into FreeTubeApp:development Apr 27, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants