Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure FT stay "running in background" on MacOS after all window closed #3526

Merged

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented May 11, 2023

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Fixes #2934

Description

I think FT already stay "running in background" on MacOS after closing all windows, but only once (due to calling once instead of on in main app code)
This PR simply changes once to on for window-all-closed event

Screenshots

Done in dev mode, so you can see the dock icon is Electron, and part of dev tool as FT window

Screen.Recording.2023-05-11.at.09.14.30.mov

Testing

  • Get on a MacOS (even VM)
  • Open app
  • Close window
  • Ensure FT dock icon lit (still running)
  • Click on dock icon
  • Ensure window created
  • Close window (2nd time)
  • Ensure FT dock icon lit (still running) (2nd time)

Desktop

  • OS: MacOS
  • OS Version:
  • FreeTube version:

Additional context

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 11, 2023 01:12
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 11, 2023
@efb4f5ff-1298-471a-8973-3d47447115dc

@QAQDE Check out the screen recording in the PR body is this the behavior u want to see?

@QAQDE
Copy link

QAQDE commented May 11, 2023

@QAQDE Check out the screen recording in the PR body is this the behavior u want to see?

Yes, it now looks completely fine. Thanks

@FreeTubeBot FreeTubeBot merged commit 4363c71 into FreeTubeApp:development May 11, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: fix close behavior on macOS
6 participants