IV: Show channel handle in search results #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
removed
the
PR: waiting for review
|
The test cases in this pull request should be tested too: #3099 |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Upstream PR finally merged letssgoooo! |
ChunkyProgrammer
added
PR: waiting for review
|
If possible i would like it to be formatted this way We do formatting like this everywhere but not here so it would be nice if that also could be addressed in here So Include • this dot Would also be nice to put handle first like YT |
ChunkyProgrammer
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
PikachuEXE
approved these changes
Oct 10, 2023
absidue
approved these changes
Oct 10, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 10, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 11, 2023
* development: IV: Show channel handle in search results (FreeTubeApp#3791) Bump electron from 22.3.25 to 22.3.26 (FreeTubeApp#4120) Bump lefthook from 1.5.0 to 1.5.2 (FreeTubeApp#4122) Bump the eslint group with 4 updates (FreeTubeApp#4119) Bump sass from 1.68.0 to 1.69.0 (FreeTubeApp#4121) Bump marked from 9.0.3 to 9.1.0 (FreeTubeApp#4123) Bump version number to v0.19.1 Fix styling for Channel page on desktop view (FreeTubeApp#4112) Set new consent cookie and supress tracking cookies on the watch page (FreeTubeApp#4013) Translated using Weblate (Italian) Update translation files Added translation using Weblate (Belarusian)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IV: Show channel handle in search results
Pull Request Type
Related issue
Video Count for channels is almost always 0 (it might always be 0)
Description
Display the channel handle when it exists + fix missing translations for ft-list-channel
Testing
Desktop
Additional context
Relies on iv-org/invidious#3994 to be merged