Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed Images Nightly #3988

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 3, 2023

Images automagically compressed by Calibre's image-actions

Compression reduced images by 57%, saving 380 bytes.

Filename Before After Improvement
_icons/iconWhiteSmall.png 667 bytes 287 bytes -57.0%

30 images did not require optimisation.

Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably update this workflow to use the bot account.

@PikachuEXE PikachuEXE closed this Sep 3, 2023
@PikachuEXE PikachuEXE reopened this Sep 3, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 3, 2023 01:16
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 3, 2023
@FreeTubeBot FreeTubeBot merged commit ba5cd96 into development Sep 3, 2023
8 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 3, 2023
@PikachuEXE PikachuEXE deleted the create-pull-request/patch-1693700483 branch September 3, 2023 01:18
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Sep 5, 2023
* development: (57 commits)
  Translated using Weblate (Italian)
  Translated using Weblate (Dutch)
  Translated using Weblate (Swedish)
  Translated using Weblate (Swedish)
  Translated using Weblate (Dutch)
  Translated using Weblate (Chinese (Traditional))
  Translated using Weblate (Japanese)
  Translated using Weblate (Romanian)
  Translated using Weblate (Estonian)
  Compressed Images (FreeTubeApp#3988)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Czech)
  Translated using Weblate (Arabic)
  Translated using Weblate (German)
  Translated using Weblate (Chinese (Simplified))
  Translated using Weblate (Persian)
  Translated using Weblate (Ukrainian)
  Translated using Weblate (Polish)
  Translated using Weblate (Persian)
  ...

# Conflicts:
#	src/renderer/components/ft-list-playlist/ft-list-playlist.js
#	src/renderer/components/playlist-info/playlist-info.js
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Sep 5, 2023
* feature/playlist-2023-05: (62 commits)
  ! Fix thumbnail not respecting backend preference
  ! Fix bug introduced by last merge
  Translated using Weblate (Italian)
  Translated using Weblate (Dutch)
  Translated using Weblate (Swedish)
  Translated using Weblate (Swedish)
  Translated using Weblate (Dutch)
  Translated using Weblate (Chinese (Traditional))
  Translated using Weblate (Japanese)
  Translated using Weblate (Romanian)
  Translated using Weblate (Estonian)
  Compressed Images (FreeTubeApp#3988)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Czech)
  Translated using Weblate (Arabic)
  Translated using Weblate (German)
  Translated using Weblate (Chinese (Simplified))
  Translated using Weblate (Persian)
  Translated using Weblate (Ukrainian)
  ...
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Sep 5, 2023
* development: (66 commits)
  Group dependabot created updates for some packages in fewer PRs (FreeTubeApp#3968)
  Chore: Update vscode configurations (FreeTubeApp#3986)
  Bump youtubei.js from 6.1.0 to 6.3.0 (FreeTubeApp#3994)
  Bump postcss from 8.4.28 to 8.4.29 (FreeTubeApp#3995)
  Bump @babel/preset-env from 7.22.10 to 7.22.14 (FreeTubeApp#3996)
  Bump marked from 7.0.5 to 8.0.0 (FreeTubeApp#3993)
  Bump electron-builder from 24.6.3 to 24.6.4 (FreeTubeApp#3992)
  Translated using Weblate (Italian)
  Translated using Weblate (Dutch)
  Translated using Weblate (Swedish)
  Translated using Weblate (Swedish)
  Translated using Weblate (Dutch)
  Translated using Weblate (Chinese (Traditional))
  Translated using Weblate (Japanese)
  Translated using Weblate (Romanian)
  Translated using Weblate (Estonian)
  Compressed Images (FreeTubeApp#3988)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Czech)
  ...

# Conflicts:
#	package.json
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Sep 6, 2023

@absidue im not sure if we can just use

repo-token: ${{ secrets.PUSH_TOKEN }}
because idk what permissions this token has. I dont want to use a token for a different usecase that maybe has too much permission for the usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants