Fix bug with tabbing into three dots menu #4022 #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
|
Thanks for your pull request, to answer your question about the ft-prompt component being used, I recommend that you take a look at this pull request #3121 (TL;DR, the share menu is shown inside a prompt on narrow screens and mobile devices, eventually it would be good if other dropdowns were updated to do the same, but will likely require some redesigning #1450). |
ChunkyProgrammer
approved these changes
Sep 20, 2023
absidue
approved these changes
Sep 20, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with tabbing into three dots menu #4022
Pull Request Type
Related issue
Closes #4022
Description
Make it possible to access the three dot menu with keyboard only (tabbing)
Screen capture
2023-09-20.14-37-26.mp4
Testing
Tested it for three dot menus on most pages, though maybe I missed some
Desktop
Additional context
All I did was add an if statement to tabindex (-1 if separator and 0 if list item) and also modify the role since ESlint was giving an error (separator and option)
Also, I don't know what ft-prompt is doing in the same component, in other parts of the code it opens a prompt but here I don't see how it can be activated? Should I apply the same changes to it?
This is my first ever pull request to open source, so any and all feedback is welcome!