Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watch page video published time parsing #4105

Merged

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented Oct 6, 2023

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Fixes #4104

Description

See related issue

YT seems to return new value for published time now

before: 2023-10-05
now: 2023-10-05T13:00:07-07:00

Screenshots

After fix
image

Testing

See #4104

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

Fix from @absidue

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 6, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 6, 2023 09:41
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving my own fix 😜

@Svallinn Svallinn self-requested a review October 7, 2023 21:15
@FreeTubeBot FreeTubeBot merged commit 0c92b63 into FreeTubeApp:development Oct 7, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 7, 2023
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Oct 8, 2023
* development:
  ! Fix playlist item fetching for local API (FreeTubeApp#4102)
  ! Fix watch page video published time parsing (FreeTubeApp#4105)
  Translated using Weblate (Serbian)
  Bump youtubei.js from 6.4.0 to 6.4.1 (FreeTubeApp#4090)
  Bump rimraf from 5.0.1 to 5.0.5 (FreeTubeApp#4091)
  Bump the stylelint group with 2 updates (FreeTubeApp#4088)
  Bump electron from 22.3.24 to 22.3.25 (FreeTubeApp#4089)
  Translated using Weblate (Bulgarian)
  Update FT history import to accept key lastViewedPlaylistId (FreeTubeApp#4038)
  Translated using Weblate (Dutch)
  Translated using Weblate (Lithuanian)
  Translated using Weblate (Japanese)
  Translated using Weblate (Croatian)
  Translated using Weblate (Estonian)
  Translated using Weblate (Croatian)

# Conflicts:
#	src/renderer/components/data-settings/data-settings.js
#	src/renderer/components/ft-list-video/ft-list-video.js
#	src/renderer/components/watch-video-info/watch-video-info.js
#	src/renderer/views/Playlist/Playlist.js
#	src/renderer/views/Watch/Watch.js
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Oct 8, 2023
* feature/playlist-2023-05: (176 commits)
  ! Fix playlist item fetching for local API (FreeTubeApp#4102)
  ! Fix watch page video published time parsing (FreeTubeApp#4105)
  Translated using Weblate (Serbian)
  Bump youtubei.js from 6.4.0 to 6.4.1 (FreeTubeApp#4090)
  Bump rimraf from 5.0.1 to 5.0.5 (FreeTubeApp#4091)
  Bump the stylelint group with 2 updates (FreeTubeApp#4088)
  Bump electron from 22.3.24 to 22.3.25 (FreeTubeApp#4089)
  Translated using Weblate (Bulgarian)
  Update FT history import to accept key lastViewedPlaylistId (FreeTubeApp#4038)
  ! Fix ft-video having different URLs in links
  Translated using Weblate (Dutch)
  Translated using Weblate (Lithuanian)
  Translated using Weblate (Japanese)
  Translated using Weblate (Croatian)
  Translated using Weblate (Estonian)
  Translated using Weblate (Croatian)
  ! Fix external player handling for video in local playlist
  Translated using Weblate (Finnish)
  Mobile/tablet channel page & share button visual improvements (FreeTubeApp#4061)
  Support multiple audio tracks and AV1 for Invidious by using the local API DASH manifest generator (FreeTubeApp#3942)
  ...
@PikachuEXE PikachuEXE deleted the fix/watch-page-publish-time branch October 19, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Title bar suddently missing on all videos
5 participants