Move hideOutlines to the utils store instead of using provide/inject #4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Oct 29, 2023
ChunkyProgrammer
approved these changes
Oct 31, 2023
kommunarr
approved these changes
Nov 17, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 21, 2023
* development: Update to silently allow channel links (with IDs) (FreeTubeApp#4347) Add hide channel option directly to More Options menu (FreeTubeApp#4228) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Spanish) Make landing page configurable (FreeTubeApp#4200) Bump @silvermine/videojs-quality-selector from 1.3.0 to 1.3.1 (FreeTubeApp#4362) Bump electron from 27.0.4 to 27.1.0 (FreeTubeApp#4363) Bump the eslint group with 1 update (FreeTubeApp#4360) Bump actions/github-script from 6 to 7 (FreeTubeApp#4361) add image to poll & updated quiz style (FreeTubeApp#4318) Move hideOutlines to the utils store instead of using provide/inject (FreeTubeApp#4246) Translated using Weblate (Kurdish (Central)) Translated using Weblate (English (United Kingdom)) Translated using Weblate (French) Translated using Weblate (German) Added translation using Weblate (Kurdish (Central)) Translated using Weblate (Slovak) # Conflicts: # src/renderer/components/ft-list-video/ft-list-video.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move hideOutlines to the utils store instead of using provide/inject
Pull Request Type
Related issue
#3850 (original pull request)
Description
In #3850 I decided to use Vue's provide/inject pattern to allow all components to show and hide outlines, while that seemed like a good idea at the time, I've since decided that it makes more sense to use the store for that, as we don't use provide/inject for anything else in FreeTube.
Testing
Showing outlines
Hiding outlines
Click anywhere
Desktop