-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local API: Support extracting about information from YouTube's new about popup #4370
Local API: Support extracting about information from YouTube's new about popup #4370
Conversation
d579e6c
to
ecf082a
Compare
Remember to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can view content in about tab for both channels
Off topic: I always use yarn && yarn dev
to avoid library version issue
…out popup (#4370) * Support extracting about information from YouTube's new about popup * Update YouTube.js from 7.0.0 to 8.0.0
Local API: Support extracting about information from YouTube's new about popup
Pull Request Type
Description
This pull request adds support for extracting the about information from YouTube's new popup, I also added support for showing the number of videos that the channel has. Auto-generated game channels like the Minecraft one below, still use the old about tab.
This doesn't fix the missing information on the about tab when Invidious is selected as the backend, as that requires changes on their side, to parse and include it in their API response.
This pull request also updates YouTube.js from 7.0.0 to 8.0.0, it contains two breaking changes, but one is for the library view that only logged in users have and the other one is because YouTube removed the
Channels
tab on the channel page, but we have "always" extracted the related channels from the home tab, so the breaking change doesn't affect us either.Testing
Gibi ASMR (has the new about popup)
https://www.youtube.com/channel/UCE6acMV3m35znLcf0JGNn7Q
Minecraft - Topic (has the old about tab)
https://www.youtube.com/channel/UCQvWX73GQygcwXOTSf_VDVg
Remember to run
yarn install
after checking out this branch, so that you get the YouTube.js update. You will also want to runyarn install
again after switching away from this branch, to downgrade YouTube.js again, otherwise you'll get errors because the development branch doesn't support the new about data structure.