-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dearrow support for thumbnails #4520
Add dearrow support for thumbnails #4520
Conversation
Is missing the tooltip label, otherwise is looking good behavior-wise. |
All Thumbnail Preferences are overwritten except for Blur. Q: Should we even overwrite thumbnail preference
|
@@ -367,6 +376,13 @@ export default defineComponent({ | |||
} | |||
}, | |||
|
|||
displayDuration: function () { | |||
if (this.useDeArrowTitles && (this.duration === '' || this.duration === '0:00') && this.deArrowCache?.videoDuration) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to test this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In the "Subscription Settings" turn on "Fetch Feeds from RSS".
- Subscribe to a channel that has dearrow titles e.g. https://www.youtube.com/@MrBeast
- On the subscription page any unwatched videos from that channel should now have durations shown (for watched videos the duration comes from the watch history).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code works, just a few small suggestions concerning performance and an outdated code comment.
Co-authored-by: absidue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…mark * development: (53 commits) Add dearrow support for thumbnails (FreeTubeApp#4520) Translated using Weblate (French) Fix hardware acceleration flag for Linux (FreeTubeApp#4532) Translated using Weblate (Bengali) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Turkish) Translated using Weblate (Spanish) Translated using Weblate (Arabic) Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (Russian) Translated using Weblate (French) Translated using Weblate (Chinese (Simplified)) Add toggle to suppress sending additional args to external players (FreeTubeApp#4515) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Italian) Translated using Weblate (French) Translated using Weblate (Finnish) Translated using Weblate (Polish) ... # Conflicts: # src/renderer/store/modules/settings.js
…m-builds/current * feature/consistent-sharable-video-url-local: (30 commits) * Update places generating sharable YT video URLs to always return prefix https://youtu.be/ Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Add dearrow support for thumbnails (FreeTubeApp#4520) Translated using Weblate (French) Fix hardware acceleration flag for Linux (FreeTubeApp#4532) Translated using Weblate (Bengali) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Turkish) Translated using Weblate (Spanish) Translated using Weblate (Arabic) Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (Russian) Translated using Weblate (French) Translated using Weblate (Chinese (Simplified)) Add toggle to suppress sending additional args to external players (FreeTubeApp#4515) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Italian) ...
Add dearrow support for thumbnails
Pull Request Type
Related issue
closes #4146
Description
This PR allows for using DeArrow for thumbnails. This PR also stores the duration of a video in the dearrow cache if available and will fallback to the dearrow duration for shorts, etc.
Screenshots
DeArrowed Screenshot:
Non DeArrowed Screenshot:
Testing
test 1
test 2
test 3
Desktop