Workaround community post slider dependency incorrectly calculating its size #4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
|
I cannot reproduce blank page on dev (tried different widths) |
ChunkyProgrammer
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Sometimes when the content is not fully loaded the page gets blank. In this clip you see 2 kind of blank pages.
- Blank page but community page border gets wider
- Blank page border stays normal
Im concerned about the first one. Is that related to the fix?
VirtualBoxVM_c7nlFZtLyn.mp4
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jan 30, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Feb 3, 2024
* development: (92 commits) Make video info section more concise (FreeTubeApp#4338) Playlist performance improvements (FreeTubeApp#4597) ! Fix playlist type not passed when playing next/prev item in a user playlist (FreeTubeApp#4623) Properly localize playlist view and video counts (FreeTubeApp#4620) Translated using Weblate (Croatian) Translated using Weblate (German) Translated using Weblate (Croatian) Fix search bar handling of Invidious channel URLs (FreeTubeApp#4568) Local API: List related games in featured channels section (FreeTubeApp#4562) Workaround community post slider dependency incorrectly calculating its size (FreeTubeApp#4598) Add support for viewing movie trailers with local api (FreeTubeApp#4391) Bump the eslint group with 2 updates (FreeTubeApp#4616) Translated using Weblate (French) Translated using Weblate (Finnish) Bump electron from 28.1.4 to 28.2.0 (FreeTubeApp#4611) Translated using Weblate (French) Bump the eslint group with 4 updates (FreeTubeApp#4581) Bump lefthook from 1.6.0 to 1.6.1 (FreeTubeApp#4608) Bump marked from 11.1.1 to 11.2.0 (FreeTubeApp#4612) Bump webpack from 5.89.0 to 5.90.0 (FreeTubeApp#4610) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround community post slider dependency incorrectly calculating its size
Pull Request Type
Related issue
closes #4486
Description
The dependency that we use for the image sliders in community posts, has a bug that makes its JavaScript severly miscalculate what size it should be, 33 million pixels wide to be exact. The workaround was taken from this issue on the swiper repository. Considering the maintainers response on that issue, it seems rather unlikely that the bug will ever get fixed (if that is really how flex and grid worked, how come every other item in the flex and grid layouts work just fine?), so I've decided to implement the proposed workaround.
Testing
Load the community tab on the subscriptions page, if you can see the posts instead of a blank page, the issue is solved.
Desktop