Fix the Invidious DASH manifest generation #4672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Feb 13, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 13, 2024
ChunkyProgrammer
approved these changes
Feb 15, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Feb 15, 2024
…-user-playlist-2 * development: (66 commits) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Estonian) Translated using Weblate (Turkish) Translated using Weblate (Spanish) Translated using Weblate (Arabic) Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (French) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Fix overflow issue with share playlist icon drop-down (FreeTubeApp#4677) Fix the Invidious DASH manifest generation (FreeTubeApp#4672) Hide channel sidebar label under `more` when setting is enabled (FreeTubeApp#4678) Translated using Weblate (Norwegian Nynorsk) Translated using Weblate (Serbian) Remove excessive punctuation as part of distraction settings (FreeTubeApp#4673) Bump the stylelint group with 1 update (FreeTubeApp#4669) Bump swiper from 11.0.5 to 11.0.6 (FreeTubeApp#4670) ... # Conflicts: # src/renderer/components/playlist-info/playlist-info.scss
absidue
added a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Invidious DASH manifest generation
Pull Request Type
Related issue
#4543
Description
Since the YouTube.js upgrade in #4543, the our DASH manifest generation for the Invidious API is broken. Rather ironically I introduced the breaking change on the YouTube.js side, did the YouTube.js upgrade on the FreeTube side and am now the one fixing the issue. Thankfully it's an easy fix.
Screenshots
Testing
Set the preferred backend to Invidious or turn on proxy through Invidious while the local API is enabled.
You shouldn't get the error in the screenshot anymore.
Desktop