Use addVideo instead of addVideos for quick bookmark button
#5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
Umm just curious what happens with this if the Batch actions PR is merged |
I haven't looked at that pull request, however if it just fakes a click on the quick bookmark button then it won't make a difference, but if that is the case then that pr should be redesigned, to call |
kommunarr
approved these changes
May 24, 2024
PikachuEXE
approved these changes
May 24, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 25, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
May 26, 2024
* development: Fix channel sort values to show the values they are (FreeTubeApp#5162) Translated using Weblate (Russian) Translated using Weblate (French) Quick bookmark button RTL & hover fixes (FreeTubeApp#5157) Use addVideo instead of addVideos for quick bookmark button (FreeTubeApp#5168) Cache quick bookmark playlist to reduce the amount of lookups (FreeTubeApp#5169) Translated using Weblate (Arabic) Translated using Weblate (Indonesian) Fix hide/show channel in ft-list-video (FreeTubeApp#5149) # Conflicts: # src/renderer/components/ft-list-video/ft-list-video.js # src/renderer/components/watch-video-info/watch-video-info.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
addVideoinstead ofaddVideosfor quick bookmark buttonPull Request Type
Description
As we already have a dedicated process for adding just one video to the playlist, we might as well use it for the quick bookmark button, as that always just adds one video. Another advantage is that the
addVideostore action, doesn't need to clone the video object, because we know it's not used anywhere else as we just created it.I'm not expecting this improvement to be drastic enough to be noticeable without measuring tools, but it's still worth it as we are doing less work and using less memory.
Testing
Check that adding a video to the quick bookmark playlist through the dedicated button on a video thumbnail and on the watch page, still works.
Desktop