Update playlist page titles #5271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
force-pushed
the
feature/better-title
branch
from
e8260d5
to
144c2e4
Compare
kommunarr
approved these changes
Jun 17, 2024
Comment on lines
+556
to
+559
| const titleText = [ | ||
| playlistTitle, | ||
| channelName, | ||
| ].filter(v => v).join(' | ') |
There was a problem hiding this comment.
JS version of ruby code like (not exact coz Array#compact only removes nil values)
[
value_a if condition_a,
value_b if condition_b,
].compact.join(' | ')
absidue
approved these changes
Jun 18, 2024
ChunkyProgrammer
approved these changes
Jun 18, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 20, 2024
* development: (120 commits) Update version number to v0.21.0 Remove limited donation methods (FreeTubeApp#5290) Translated using Weblate (Portuguese) Translated using Weblate (Portuguese (Portugal)) Avoid cloning all profiles when subscribing and unsubscribing (FreeTubeApp#5289) Fix arrow keys not working in the Create New Playlist prompt (FreeTubeApp#5243) Bump ws from 8.16.0 to 8.17.1 (FreeTubeApp#5291) Remove a few bits of unused code (FreeTubeApp#5287) Update About page to display correct Freetube logo based on currently set theme (FreeTubeApp#5126) Translated using Weblate (Croatian) * Update playlist page titles (FreeTubeApp#5271) Update Invidious instances list (FreeTubeApp#5288) Translated using Weblate (Polish) Bump the eslint group with 2 updates (FreeTubeApp#5275) Bump marked from 12.0.2 to 13.0.0 (FreeTubeApp#5276) Bump sass from 1.77.4 to 1.77.5 (FreeTubeApp#5277) Bump lefthook from 1.6.15 to 1.6.16 (FreeTubeApp#5279) Bump webpack from 5.91.0 to 5.92.0 (FreeTubeApp#5278) Update Flatpak PR Workflow to work with updated module (FreeTubeApp#5270) Translated using Weblate (Portuguese) ...
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 20, 2024
* development: (102 commits) Update version number to v0.21.0 Remove limited donation methods (FreeTubeApp#5290) Translated using Weblate (Portuguese) Translated using Weblate (Portuguese (Portugal)) Avoid cloning all profiles when subscribing and unsubscribing (FreeTubeApp#5289) Fix arrow keys not working in the Create New Playlist prompt (FreeTubeApp#5243) Bump ws from 8.16.0 to 8.17.1 (FreeTubeApp#5291) Remove a few bits of unused code (FreeTubeApp#5287) Update About page to display correct Freetube logo based on currently set theme (FreeTubeApp#5126) Translated using Weblate (Croatian) * Update playlist page titles (FreeTubeApp#5271) Update Invidious instances list (FreeTubeApp#5288) Translated using Weblate (Polish) Bump the eslint group with 2 updates (FreeTubeApp#5275) Bump marked from 12.0.2 to 13.0.0 (FreeTubeApp#5276) Bump sass from 1.77.4 to 1.77.5 (FreeTubeApp#5277) Bump lefthook from 1.6.15 to 1.6.16 (FreeTubeApp#5279) Bump webpack from 5.91.0 to 5.92.0 (FreeTubeApp#5278) Update Flatpak PR Workflow to work with updated module (FreeTubeApp#5270) Translated using Weblate (Portuguese) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Partially due to #5003 (comment)
Description
Update page title for single playlist page
Screenshots
Remote Playlist (Local/IV API both look the same)
User Playlist
Testing
Desktop
Additional context