Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live chat scroll down sometimes not removing the Scroll Down arrow #5302

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

kommunarr
Copy link
Collaborator

Fix live chat scroll down sometimes not removing the Scroll Down arrow

Pull Request Type

  • Bugfix

Related issue

closes #3158

Description

Adds @scrolldown event handler to evaluate the position at end of the scroll event as well

Testing

  • Find a live video (I used this one), scroll up, and scroll down fast. See that the arrow icon disappears properly

Desktop

  • OS: OpenSUSE
  • OS Version: TW

@kommunarr kommunarr added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 21, 2024
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 21, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 21, 2024 14:16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaay, LGTM!

@FreeTubeBot FreeTubeBot merged commit 4592b18 into FreeTubeApp:development Jun 22, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Livechat scrolling down doesn't hide arrow button
5 participants