Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Rename the setting from Avoid Accidental Unsubscription to Confirm before unsubscribing #5342

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Feature: Rename the setting from Avoid Accidental Unsubscription to Confirm before unsubscribing #5342

merged 2 commits into from
Jun 26, 2024

Conversation

Jaishree2310
Copy link
Contributor

@Jaishree2310 Jaishree2310 commented Jun 26, 2024 •
edited by absidue
Loading

close #5340

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Description

Screenshots

Testing

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 26, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 26, 2024 16:38
kommunarr
kommunarr reviewed Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@kommunarr kommunarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

suggestion (blocking): The label should be in title case to match with the surrounding labels.

@Jaishree2310 Jaishree2310 changed the title feature: rename the setting from Avoid Accidental Unsubscription to Confirm before unsubscribing Feature: Rename the setting from Avoid Accidental Unsubscription to Confirm before unsubscribing Jun 26, 2024
auto-merge was automatically disabled June 26, 2024 17:00

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 26, 2024 17:01
@FreeTubeBot FreeTubeBot merged commit cafcaf8 into FreeTubeApp:development Jun 26, 2024
6 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

@kommunarr kommunarr kommunarr approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc Awaiting requested review from efb4f5ff-1298-471a-8973-3d47447115dc

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Rename "Avoid Accidental Unsubscription" to "Confirm before unsubscribing"
5 participants
@Jaishree2310 @PikachuEXE @absidue @kommunarr @FreeTubeBot