-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use streams from the iOS client to workaround playback issues #5472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing it daily~
Livestream: Lofi https://youtu.be/_uMuuHk_KkQ |
What Music video is the testing referring to? |
Music videos have stronger restrictions on them, e.g. geo restrictions and on the website you need to do extra steps to get them to play. So any music video should work, the main thing is just to check that it plays. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No random 403 so far in my custom build (with shaka
Let me test this until Tuesday
Okay that definitely shouldn't be happening, it's also interesting that it is random, I wonder if it has anything to do with this pull request using random app versions and iOS versions. |
Built a custom build printing client version and iOS version 1st: |
also using Pikachu's shaka build I did skip from 0:58 -> 1:10 |
I can't reproduce with that video yet I only got 1 jump so far |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No jump detected for the last day
Not such a big issue to prevent merging
Retested, havent seen any weird skips |
Last time it requires 5x videos to 1-3 skips |
…beApp#5472) * Use streams from the iOS client to workaround playback issues * Fix for unplayable videos * Hoist version arrays and introduce a randomArrayItem helper
…beApp#5472) * Use streams from the iOS client to workaround playback issues * Fix for unplayable videos * Hoist version arrays and introduce a randomArrayItem helper
…o workaround playback issues (#5508) * ^ Update youtubei.js * Use streams from the iOS client to workaround playback issues (#5472) * Use streams from the iOS client to workaround playback issues * Fix for unplayable videos * Hoist version arrays and introduce a randomArrayItem helper --------- Co-authored-by: absidue <[email protected]>
…ctions - ^Update youtubei.js - Use streams from the iOS client to workaround playback issues (FreeTubeApp#5472) - Allow user agent spoofing for usage of iOS client
…ctions - ^Update youtubei.js - Use streams from the iOS client to workaround playback issues (FreeTubeApp#5472) - Allow user agent spoofing for usage of iOS client
It just dawned on me that the weird skips arent maybe related to this PR but to FT in general. Users of adblockers reported on reddit that they have seeing black screens for 5-15sec and it might be related to sever side ad injection Could that explain the random skips? |
That definitely would make sense and would also explain why it doesn't happen very often yet, because YouTube hasn't fully rolled them out yet. |
* development: Bump version number to v0.21.3 Bump sass-loader from 14.2.1 to 16.0.0 (FreeTubeApp#5495) ^ Update youtubei.js (FreeTubeApp#5507) Use streams from the iOS client to workaround playback issues (FreeTubeApp#5472)
Use streams from the iOS client to workaround playback issues
Pull Request Type
Related issue
closes #5453
closes #5370
Description
As YouTube is currently introducing various changes to the WEB client, which cause the random 403s and the random
No valid URL to decipher
errors. This pull request aims to solve both of those issues, by using the DASH streams from the iOS client instead. Age-restricted videos are still expected to have the random 403s problem, as the client we use to bypass the forced login, has the same problems as the WEB client. I've had to add overrides in a few places to get it to actually work, such as the User-Agent, however those overrides should only affect iOS requests.Unfortunately the iOS client doesn't have the opus audio streams.
Testing
Please test this pull request thoroughly with various different videos (e.g. normal, live streams, age-restricted, music).
Age-restricted videos are still expected to have the random 403s problem.
Desktop