Use constants for API names #5693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
reviewed
Sep 12, 2024
| this.pageNumber = 1 | ||
| }, | ||
|
|
||
| getHashtag: async function() { | ||
| const hashtag = decodeURIComponent(this.$route.params.hashtag) | ||
| if (this.backendFallback || this.backendPreference === 'local') { |
There was a problem hiding this comment.
Yeah, it's something i noticed while switching to the constants (i included it in the description)
Comment on lines
+111
to
+113
| export const API_DATA_SOURCES = { | ||
| LOCAL_API: 'local', | ||
| INVIDIOUS_API: 'invidious' |
There was a problem hiding this comment.
Since you named it as API_DATA_SOURCES, why include API in constants names too?
| @@ -384,7 +385,7 @@ export function filterInvidiousFormats(formats) { | |||
| }) | |||
| } | |||
|
|
|||
| export async function getHashtagInvidious(hashtag, page) { | |||
| export async function getHashtagInvidious(hashtag, page = 1) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use constants for API names
Pull Request Type
Related issue
Since we reuse 'local' and 'invidious' a lot in our code, I thought it'd be a good idea to use constants for those instead
Description
Desktop