Use BCP 47 compatible languages codes for all locales #5723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
absidue
added
the
PR: low priority
PikachuEXE
approved these changes
Sep 22, 2024
ChunkyProgrammer
approved these changes
Sep 22, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 23, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use BCP 47 compatible languages codes for all locales
Pull Request Type
Description
FreeTube has 3 locales that use underscores in their codes (en_GB, es_AR and nb_NO), the rest of them use hyphens. As all web APIs expect BCP 47 compatible language codes, we end up having to replace the underscores with hyphens in many places in the code. This pull request converts those 3 locales to use hyphens, that allows us to cleanup all the code that has to handle both underscores and hyphens. It also includes a one time migration for users that are currently using those locales.
Testing
English (UK)Desktop