gpu-viv: change _QuerySignal return from gctBOOL to gceSTATUS #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gcc 13 build error:
| /srv/oe/build/tmp-lmp/work-shared/imx8ulp-lpddr4-evk/kernel-source/drivers/mxc/gpu-viv/hal/os/linux/kernel/gc_hal_kernel_os.c:5675:1: error: conflicting types for '_QuerySignal' due to enum/integer mismatch; have 'gceSTATUS(struct _gckOS *, void *)' {aka 'enum _gceSTATUS(struct _gckOS *, void *)'} [-Werror=enum-int-mismatch]
| 5675 | _QuerySignal(IN gckOS Os, IN gctSIGNAL Signal)
| | ^~~~~~~~~~~~
| In file included from /srv/oe/build/tmp-lmp/work-shared/imx8ulp-lpddr4-evk/kernel-source/drivers/mxc/gpu-viv/hal/os/linux/kernel/gc_hal_kernel_os.c:56:
| /srv/oe/build/tmp-lmp/work-shared/imx8ulp-lpddr4-evk/kernel-source/drivers/mxc/gpu-viv/hal/os/linux/kernel/gc_hal_kernel_linux.h:341:1: note: previous declaration of '_QuerySignal' with type 'gctBOOL(struct _gckOS *, void *)' {aka 'int(struct _gckOS *, void *)'}
| 341 | _QuerySignal(IN gckOS Os, IN gctSIGNAL Signal);
| | ^~~~~~~~~~~~
Signed-off-by: Jose Quaresma <[email protected]>
MrCry0
approved these changes
Jun 21, 2023
|
Please fix it here as well: https://github.com/Freescale/kernel-module-imx-gpu-viv |
otavio
approved these changes
Jun 21, 2023
Look like this one is already fixed by @kraj Freescale/kernel-module-imx-gpu-viv@43f9d48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gcc 13 build error:
Tested on
imx8ulp-lpddr4-evkmachine.