This repository has been archived by the owner on May 28, 2022. It is now read-only.
Configuration API Controller #632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I left some comments on the gdoc. |
FranciscoCanas
force-pushed
the
configuration-api
branch
from
268148e
to
332d753
Compare
This was referenced Nov 2, 2014
FranciscoCanas
added a commit
to FranciscoCanas/freeseer
that referenced
this pull request
Nov 16, 2014
Methods for deleting, creating, and listing profiles. Also modifies get_profile by adding an extra arg to specify whether a non- existing profile should be auto-created. Adds unit tests to test_profile. Methods added: - create - list_profiles - delete Related to Freeseer#632
FranciscoCanas
force-pushed
the
configuration-api
branch
from
e0a923e
to
603c99a
Compare
FranciscoCanas
changed the title
FranciscoCanas
force-pushed
the
configuration-api
branch
from
bfd13fe
to
a10ea7b
Compare
FranciscoCanas
added a commit
to FranciscoCanas/freeseer
that referenced
this pull request
Nov 20, 2014
Config schema methods generate a json schemas based on the config instance's options. Option schema methods generate schemas based on the type of Option, its default values, and whether its required or not. Also adds schema unit tests for Config and Options, and adds test_float unit test file. Needed for Freeseer#632
FranciscoCanas
force-pushed
the
configuration-api
branch
2 times, most recently
from
2a31784
to
fe443ce
Compare
|
I suggest you move your code into a submodule folder instead of prefixing files with |
FranciscoCanas
force-pushed
the
configuration-api
branch
from
526dde9
to
6911125
Compare
Adds endpoints for: - User profiles - General and Recording configuration - Recording Plugins Helper methods and unit tests for all implemented endpoints.
FranciscoCanas
force-pushed
the
configuration-api
branch
from
54ecb06
to
f2326a9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the Configuration API as described here:
https://docs.google.com/document/d/1efjdlFTFlYLX0XOYs1hIjBC6rxLRXBjMjiqUdPBHqSc/
Completed:
Note:
Freeseer's PluginManager has no support for listing available instances of some given plugin, and doesn't keep track of existing instances. The PluginManager will require some expansion, partly as described in #416, in order to fully support selecting specific plugin instances through this api.