feat: logger class #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logging solution is still inadequate and needs improvement. This PR makes it easier to track the log messages or
migrate later, we have considered using Kotlin logging solutions though most of them depend on a Java logging library for the JVM implementation, which makes the bundle size bigger (0.10 MB to 6 MB).
Notice the messages that are printed to the log will be shown when running the script using the command line or in the launcher, which is why we avoided printing log info at the start of the message:
[main] INFO Main - ${message}.We might use Java logging since it's already part of the JDK and will be used in development mode to filter the messages by log level and scope.