Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPStan and other quality checks #185

Merged
merged 15 commits into from
Nov 24, 2023
Merged

Add PHPStan and other quality checks #185

merged 15 commits into from
Nov 24, 2023

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Nov 23, 2023

Similar to FreshRSS core
Contributes to #184
Uses FreshRSS/FreshRSS#5901

TODO:

  • Check compatibility with PHP 7.4 - PHP 8.3

Similar to FreshRSS core
Contributes to #184
@Alkarex
Copy link
Member Author

Alkarex commented Nov 23, 2023

Only lacking a bit of work on:

  • ./xExtension-ImageProxy/configure.phtml
  • ./xExtension-ImageProxy/extension.php

Any takers please 🙏🏻?
Maybe @Frenzie or @ColonelMoutarde?

This PR can be also merged as-is after a bit of testing.
Anyone to give it a try? @lapineige or @math-GH maybe?

@Alkarex
Copy link
Member Author

Alkarex commented Nov 23, 2023

I thought there was an issue (maybe by @math-GH ) somewhere about doing this PR, but I cannot find it at the moment... (Hints welcome)

@lapineige
Copy link
Contributor

I've no time to test it, sorry.

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Nov 23, 2023
@Frenzie
Copy link
Member

Frenzie commented Nov 24, 2023

@Alkarex Probably not for a week, slightly depending on the weather.

Alkarex added a commit to FreshRSS/FreshRSS that referenced this pull request Nov 24, 2023
* Fix types for extensions
To accompany FreshRSS/Extensions#185

* Avoid bug redeclared function
@Alkarex Alkarex merged commit fabd980 into master Nov 24, 2023
1 check passed
@Alkarex Alkarex deleted the phpstan branch November 24, 2023 16:04
@math-GH
Copy link
Contributor

math-GH commented Nov 24, 2023

Sorry, I am late to the party.
In my first check I saw an PHP error with 1.22.2-dev about 10 commits behind. I mean: Does this PR works fine with the current 1.22.1? The users have 1.22.1 installed and add extensions from the repository. Sure that the current extensions (that includes this PR) work fine?

@Alkarex
Copy link
Member Author

Alkarex commented Nov 24, 2023

No, there is no possible path of update without also making a new FreshRSS release, so we need to issue 1.23.0 as soon as possible.
It also indicates the need to have some version ranges for compatibility in the metadata. FreshRSS/FreshRSS#5903
Help very much wanted in finalising the work on the extension updates (tests in particular, before the release of 1.23.0)

xExtension-ImageProxy is also in need of a caring hand (maybe @ColonelMoutarde while @Frenzie is away)

@Alkarex
Copy link
Member Author

Alkarex commented Nov 24, 2023

What lacks most urgently is testing the compatibility with older third-party extensions, which have not been updated.
Edit: this looks ok, at a quick glance (edge, with PHP 7.4, 8.2, 8.3) - more tests welcome

@Alkarex
Copy link
Member Author

Alkarex commented Nov 24, 2023

Related: FreshRSS/FreshRSS#5837

Alkarex added a commit to Alkarex/xExtension-WhiteList that referenced this pull request Dec 30, 2023
Alkarex added a commit that referenced this pull request Jan 15, 2024
Partial follow-up of #185 (comment)
Fix regression in typing for `getSrcSetUris`()
Alkarex added a commit that referenced this pull request Feb 29, 2024
Partial follow-up of #185 (comment)
Fix regression in typing for `getSrcSetUris`()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants