Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image proxy extension: update to wsrv.nl and add German #208

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Feb 29, 2024

Image proxy extension: update to wsrv.nl and add German

@math-GH math-GH added the xExtension-ImageProxy xExtension-ImageProxy label Feb 29, 2024
@math-GH math-GH requested a review from Frenzie February 29, 2024 19:29
@Alkarex
Copy link
Member

Alkarex commented Feb 29, 2024

With a little reminder that this is the only remaining extension not passing PHPStan level 9
https://github.com/FreshRSS/Extensions/blob/master/tests/phpstan-next.txt
#202

@Frenzie Frenzie merged commit 4e0155e into master Feb 29, 2024
1 check passed
@Frenzie Frenzie deleted the URL-to-wsrv.nl branch February 29, 2024 19:50
@Frenzie
Copy link
Member

Frenzie commented Feb 29, 2024

Thanks!

@Frenzie
Copy link
Member

Frenzie commented Feb 29, 2024

@Alkarex

With a little reminder that this is the only remaining extension not passing PHPStan level 9 https://github.com/FreshRSS/Extensions/blob/master/tests/phpstan-next.txt

The line in that file gives me the following result:

find . -type d -name 'vendor' -prune -o -name '*.php' -exec sh -c 'vendor/bin/phpstan analyse --level 9 --memory-limit 512M {} >/dev/null 2>/dev/null || echo {}' \;
./xExtension-ReadingTime/extension.php
./xExtension-QuickCollapse/extension.php
./xExtension-QuickCollapse/Controllers/quickCollapseController.php
./xExtension-QuickCollapse/Models/View.php
./xExtension-showFeedID/extension.php
./xExtension-CustomCSS/extension.php
./xExtension-ShareByEmail/mailers/Share.php
./xExtension-ShareByEmail/extension.php
./xExtension-ShareByEmail/Controllers/shareByEmailController.php
./xExtension-ShareByEmail/Models/View.php
./xExtension-CustomJS/extension.php
./xExtension-ImageProxy/extension.php
./xExtension-TitleWrap/extension.php
./xExtension-StickyFeeds/extension.php
./xExtension-ColorfulList/extension.php

@Frenzie
Copy link
Member

Frenzie commented Feb 29, 2024

All the errors are about unknown classes.

At a glance I presume that means (some of) these are the actual warnings:

  134    Parameter #2 $callback of function preg_replace_callback expects                         
         callable(array<int|string, string>): string, Closure(mixed): array<string> given.        
  135    Parameter #2 $value of method DOMElement::setAttribute() expects string, string|null     
         given.                                                                                   
  142    Method ImageProxyExtension::setImageProxyHook() has invalid return type FreshRSS_Entry.  
  142    Parameter $entry of method ImageProxyExtension::setImageProxyHook() has invalid type     
         FreshRSS_Entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
xExtension-ImageProxy xExtension-ImageProxy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants