Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BuffsList.inc / Asset for Spear Buff #59

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

Gramgoyle
Copy link
Contributor

Added new Buff from Spear Skill to some professions (Engineer, Mesmer, Necromancer, Guardian, Revenant, Ranger)

First time to do dis kind of thing please double check >.<. Tried to upload the buff icon to asset but it said no push . So I guess I just upload it here ?

thank you for making Clarity ♥

Abyssal_Raze
Clarity
Focused
Illuminated
Panther's_Prowl
Soul_Shards

Added new Buff from Spear Skill to some professions (Engineer, Mesmer, Necromancer, Guardian, Revenant, Ranger)
@Gramgoyle
Copy link
Contributor Author

OwO I just notice some new buff that I can add for spear

@Gramgoyle
Copy link
Contributor Author

Additional icon for buffs

So for Energize and Harden in game it still place holder so I use the skill icon for it instead (just like Seethe and Ripple in-game)

Distracting_Throw
Energize
Harden
Lightning_Rod_(engineer_spear_skill)
Ripple
Seethe
Symbol_of_Luminance_(effect)

@Friendly0Fire
Copy link
Owner

Can you please verify with the PR build whether the buffs work correctly? I currently don't have spear builds setup so I can't easily check.

https://github.com/Friendly0Fire/GW2Clarity/actions/runs/10550034318/artifacts/1852274262

@Gramgoyle
Copy link
Contributor Author

All Spear buff works correctly :D Thank you!
Sorry for the typo >.<

@Gramgoyle Gramgoyle closed this Aug 26, 2024
@Friendly0Fire Friendly0Fire reopened this Aug 26, 2024
@Friendly0Fire Friendly0Fire merged commit c1dc0b8 into Friendly0Fire:master Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants