-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue that allowed users to create private discussions with users who are blocking them #175
Fix an issue that allowed users to create private discussions with users who are blocking them #175
Conversation
193aacd
to
0339d15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine.
I see some other things which I want to question in the code, but nothing that wasn't already there before this PR, so I'm happy to get this merged.
Nowadays for our JS, we tend to prefer named functions rather than arrow ones. This is because it makes it easier to debug when issues occur (since DevTools will show the function name rather than "anonymous", for example).
Co-authored-by: David Wheatley <[email protected]>
@davwheat Ok, I changed this function |
Fixes #173
Changes proposed in this pull request:
This PR fixes an issue that allowed users to create private discussions with users who are blocking them.
Confirmed