Loading/reloading the page from /all breaks the selected language filter

[iamdarkle]

Bug Report

As the title says, loading/reloading the page from forum.com/all breaks the selected language filter, for some reason the filter is broken and loads another language/s.

It is important to emphasize that this only happens from the /all page, in my case I have noticed it easily since I use a different home page and I have to access the forum through /all the problem is constant and is quite annoying.

I have been able to reproduce the error in any Flarum instance, here I leave 2 examples: example1 and example2

[dsevillamartin]

This happens to me on both /all and / with the following options:

The dropdown shows "English" even though what it should say was "no language selected" or something similar. I have a feeling this was introduced by #15.

[iamdarkle]

Oh ok, for me in / it's a bit random, maybe it's due to my cache (?) so do you think this is also related? I reported it in the Blog extension thinking it was a problem of the blog extension, now I doubt v17development/flarum-blog#94

In the blog when going backwards the language filter disappears, in fact, the dropdown is empty and thus no posts are shown as all posts have a language assigned to them:

[dsevillamartin]

Did not mean to close this issue, look like i referenced the wrong one.

[iamdarkle]

I've been testing a bit, as far as I could see with version 1.0.0 of the extension which was before #15 also produced this error, I tried on an old test site with beta 16 and it also happens so I cannot say at what point the error was introduced.

With this I guess the blog error (mentioned above) is a blog extension thing(?) as this error appeared from 1.0 onwards, in beta 16 this didn't happen.

[imorland]

This issue requires fixes in several areas. I have the fix locally for this extension, which I'll push later today, but it also depends on flarum/framework#3037 and flarum/tags#141

These will likely be included in the next scheduled release from the core team 🤞

[iamdarkle]

It looks like those changes were merged in 1.1, does that mean it's been fixed? I haven't updated yet in the environment where I use this extension, I'll try to update on this when I do so I won't forget to close the issue if it's fixed.

[imorland]

Yes, with flarum/core 1.1.0 and 1.2.0 of this extension, the issue should now be resolved

[iamdarkle]

Yesterday I started to test 1.2.0 with two languages English and Spanish and it seemed that there was still something wrong, mainly what I experienced was

The language detection was different from the language selector of the page (language pack), for example, all the discussions appeared in Spanish when the default language pack of the page is English, but this was only for the first posts, when I clicked on "Load more" they did appear in English.

The language detection is around the language selected in the language pack selector (core)? or is it based on something else?

[iamdarkle]

Sorry @imorland I didn't notice that 1.2.1 had been released, I noticed it now when I did a composer update by chance, I don't know very well what this update fixed, but by updating the problems mentioned in my last comment have disappeared, thank you very much for fixing this annoying problem! I close the issue.

[iamdarkle]

I'm not sure what is wrong here but eventually I keep experiencing weird things with this. I'm not able to describe exactly what to do as it seems to be pretty random, but every now and then when entering the /all page the discussions appear in mixed languages again, some users especially have notified me that they have experienced this in Firefox. On the other hand, flarum/sticky doesn't seem to work and causes problems as the pinned discussions are shown in all languages, even though it defaults to English.

[dsevillamartin]

1.2.3 may have addressed some of these issues? Unsure. There seem to be a lot of different things discussed in this issue as well.

[iamdarkle]

Ok, thanks, I will look into this when I upgrade to the latest version, honestly tracing the specific cause or steps to reproduce this has been really complicated during these months... as you say this problem already contains a lot of things, probably if the issue continues I will close this and open a new one.