Pass filter params #141
Merged
Pass filter params #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested changes
Aug 20, 2021
src/Content/Tag.php
Outdated
| @@ -77,6 +78,8 @@ public function __invoke(Document $document, Request $request) | |||
| 'page' => ['offset' => ($page - 1) * 20, 'limit' => 20] | |||
| ]; | |||
|
|
|||
| $params['filter'] = array_merge($params['filter'], $filters); | |||
There was a problem hiding this comment.
$filters should override $params['filter'] on collision, so these should be swapped
There was a problem hiding this comment.
🙈 whoops, apologies. Swapped
askvortsov1
approved these changes
Aug 20, 2021
This was referenced Aug 20, 2021
SychO9
approved these changes
Aug 26, 2021
askvortsov1
pushed a commit
that referenced
this pull request
Mar 11, 2022
* Pass params to getApiDocument * Reverse arrays
askvortsov1
pushed a commit
that referenced
this pull request
May 10, 2022
* Pass params to getApiDocument * Reverse arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, any
filterparams that are passed toContent\Tagsare ignored. As discussed with @askvortsov1 here is a solution...Similar PR will be opened for core shortly :)