Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sylius 1.10 support #264

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Add Sylius 1.10 support #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da6c33f
add sylius 1.10
oallain Jul 3, 2021
75470f9
add Sylius AdminApiBundle for sylius 1.10
oallain Jul 3, 2021
96d58e2
fix phpunit config
oallain Jul 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,23 @@ jobs:
runs-on: ubuntu-latest

name: "Sylius ${{ matrix.sylius }}, PHP ${{ matrix.php }}, Symfony ${{ matrix.symfony }}, MySQL ${{ matrix.mysql }}"

strategy:
fail-fast: false
matrix:
php: [7.4, 7.3]
symfony: [^4.4, ^5.2]
sylius: [~1.8.0, ~1.9.0]
sylius: [~1.8.0, ~1.9.0, ~1.10.0]
node: [10.x]
mysql: [5.7]

exclude:
-
sylius: ~1.8.0
symfony: ^5.2
-
sylius: ~1.10.0
php: 7.3

env:
APP_ENV: test
Expand Down Expand Up @@ -108,6 +111,11 @@ jobs:
if: matrix.sylius != ''
run: composer require "sylius/sylius:${{ matrix.sylius }}" --no-update --no-scripts --no-interaction

-
name: Add Admin API Bundle for Sylius >= 1.10
if: matrix.sylius != '~1.8.0' && matrix.sylius != '~1.9.0'
run: composer require sylius/admin-api-bundle --no-update --no-scripts --no-interaction

-
name: Install PHP dependencies
run: composer install --no-interaction
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "MIT",
"require": {
"php": "^7.3",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to allow php8 ? 😇

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not without addressing #260 at a minimum.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if you feel like PR will be welcome.

"sylius/sylius": "~1.8.0 || ~1.9.0",
"sylius/sylius": "~1.8.0 || ~1.9.0 || ~1.10.0",
"portphp/portphp": "^1.2",
"symfony/stopwatch": "^4.4 || ^5.2",
"queue-interop/queue-interop": "^0.6.2 || ^0.7 || ^0.8"
Expand Down
4 changes: 2 additions & 2 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
<testsuite name="SyliusImportExportPlugin Test Suite">
<directory>tests</directory>
</testsuite>
<server name="APP_ENV" value="test"/>
<env name="SHELL_VERBOSITY" value="-1" />
</testsuites>

<php>
<server name="APP_ENV" value="test"/>
<env name="SHELL_VERBOSITY" value="-1" />
<server name="KERNEL_CLASS_PATH" value="/tests/Application/AppKernel.php" />
<server name="IS_DOCTRINE_ORM_SUPPORTED" value="true" />
</php>
Expand Down