Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA workflow to check sound file references / credits #32

Merged
merged 4 commits into from
Mar 17, 2022
Merged

GHA workflow to check sound file references / credits #32

merged 4 commits into from
Mar 17, 2022

Conversation

dseguin
Copy link
Contributor

@dseguin dseguin commented Mar 11, 2022 •
edited
Loading

Contributes to #29.

Adds a workflow to verify that:

  • each sound file is referenced in at least one sound_effect / playlist
  • each sound file has an entry in a credits file

Demo:
Failed run (unmatched credit entries): https://github.com/dseguin/CDDA-Soundpacks/runs/5507624302
Successful run (fixed credits): https://github.com/dseguin/CDDA-Soundpacks/runs/5507639321

@Fris0uman Fris0uman merged commit d4e0eec into Fris0uman:main Mar 17, 2022
@Fris0uman
Copy link
Owner

Very nice!

@Fris0uman Fris0uman mentioned this pull request Mar 17, 2022
Open
5 tasks
@dseguin dseguin deleted the gha_sndfile_check branch March 17, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dseguin @Fris0uman